-
Notifications
You must be signed in to change notification settings - Fork 51
Major overhaul including code refactoring and tutorial changes #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited proportional flag to improve naming convention consistency. Also removed duplicate code
…removed duplicate code in dabest_object file
… not in order with the dataframe itself
…tom_pal should now work with all types of plots
> Changed mini_meta attribute to is_mini_meta to better fit with other attributes (such as is_paired and is_proportional) > Changed mini_meta_delta class to mini_meta to better fit with other attributes such as delta_delta
…s. Also added an is_delta_delta property > Trim down repeated code by creating a new function to pick the color for the contrast/swarm/summary bars > added an is_delta_delta property
> Fix capitalisations and naming terminology (E.g., using Hedges' g now instead of hedges g) > Major edits to forestplot - removing excess code, removing redundant code, tidying up functions, adding extra error checks, edit some functionality > fixed some incorrect image tests > Removed the delta_g dabest attribute and shifted it to hedges_g to better fit the theme of the package > Fixed functionality where delta2=True and effect_size is not hedges_g or mean_diff but it still generates delta_g data (not supposed to happen) > updated some code that will be redundant in future python version (~isinstance)
…o one function > Trimmed excess code > Created one function to be used for plotting both the swarm bars and contrast bars >tidied up some code snippets and layout of the plotter code
…to use hedges_g when delta2=True
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.